-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make malicious url test more robust to env differences #3748
Conversation
Passing run #3083 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this @adamsachs ! The check failures are a surprise, mypy passes locally for me and the rest look like codecov upload problems. Not sure if we wanted to retry or what
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3748 +/- ##
===========================================
+ Coverage 65.20% 87.12% +21.92%
===========================================
Files 311 311
Lines 19069 19069
Branches 2462 2462
===========================================
+ Hits 12434 16614 +4180
+ Misses 6197 2027 -4170
+ Partials 438 428 -10 ☔ View full report in Codecov by Sentry. |
thanks @SteveDMurphy, the mypy issue is this other fun issue that we're already working on, nothing caused by this PR 👍 |
Closes #3736
Description Of Changes
Mock the admin UI response for our test case to get a more predictable value.
It's not ideal, since there's a slight chance this could lead to false positives in the test case if we adjust our code around this area, so we'll just need to be a bit careful there. But I think it's a good enough test for now - and certainly better than getting false negatives all the time!
Code Changes
get_admin_index_as_response
function for ourtest_malicious_url
test case to get a more predictable value to evaluate in the testSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md